r2462, why commit a generated file?

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

r2462, why commit a generated file?

Pierre Ossman-3
As the subject states, why commit the generated file jconfig.h.in?
Having two AC_CONFIG_HEADERS() confuses autoheader and any weary
developers.

I propose having jconfig.h.in removed from the repo and just the single
AC_CONFIG_HEADERS().

Rgds
--
Pierre Ossman            OpenSource-based Thin Client Technology
System Developer         Telephone: +46-13-21 46 00
Cendio AB                Web: http://www.cendio.com

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
VNC-Tight-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/vnc-tight-devel

signature.asc (204 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: r2462, why commit a generated file?

Adam Tkac
On Wed, Jan 14, 2009 at 01:38:13PM +0100, Pierre Ossman wrote:
> As the subject states, why commit the generated file jconfig.h.in?
> Having two AC_CONFIG_HEADERS() confuses autoheader and any weary
> developers.
>
> I propose having jconfig.h.in removed from the repo and just the single
> AC_CONFIG_HEADERS().
>

If you use only one autogenerated config.h.in header that header
contains redundant definitions (like PACKAGE_* macros etc).

Then when you are compiling common/* subtree with jpeg distributed
with tightvnc there are multiple definitions of PACKAGE_* macros thus
warnings are printed. (first definition comes from common/config.h and
second comes from common/jpeg/config.h). This is reason why
jconfig.h.in is commited. It is only subset of config.h.in and it
doesn't contain redundant symbols. It is standard approach.

Regards, Adam

--
Adam Tkac, Red Hat, Inc.

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
VNC-Tight-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/vnc-tight-devel
Reply | Threaded
Open this post in threaded view
|

Re: r2462, why commit a generated file?

Pierre Ossman-3
On Wed, 14 Jan 2009 14:35:34 +0100
Adam Tkac <[hidden email]> wrote:

> On Wed, Jan 14, 2009 at 01:38:13PM +0100, Pierre Ossman wrote:
> > As the subject states, why commit the generated file jconfig.h.in?
> > Having two AC_CONFIG_HEADERS() confuses autoheader and any weary
> > developers.
> >
> > I propose having jconfig.h.in removed from the repo and just the single
> > AC_CONFIG_HEADERS().
> >
>
> If you use only one autogenerated config.h.in header that header
> contains redundant definitions (like PACKAGE_* macros etc).
>
> Then when you are compiling common/* subtree with jpeg distributed
> with tightvnc there are multiple definitions of PACKAGE_* macros thus
> warnings are printed. (first definition comes from common/config.h and
> second comes from common/jpeg/config.h).
I see. The problem then is really that autoconf stuff got included into
the library header file. [j]config.h should only be used for building
the library, not users of the library.

Rgds
--
Pierre Ossman            OpenSource-based Thin Client Technology
System Developer         Telephone: +46-13-21 46 00
Cendio AB                Web: http://www.cendio.com

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
VNC-Tight-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/vnc-tight-devel

signature.asc (204 bytes) Download Attachment