Quantcast

Re: Patches for compilation with mingw32-gcc-4.1.2

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patches for compilation with mingw32-gcc-4.1.2

Constantin Kaplinsky
Hello Dick,

>>>>> Dick wrote:

> I've created a patch for tightvnc-1.3.9_winsrc.tar.bz2 to compile the
> sources using mingw32-gcc-4.1.2 (I'm cross compiling from Linux)

I think this particular change does not look good:

-     SETPIXEL(m_hBitmapDC, j,k, COLOR_FROM_PIXEL##bpp##(pix)); \
+     SETPIXEL(m_hBitmapDC, j,k, COLOR_FROM_PIXEL32(pix)); \

Also, changing slashes to backslashes in the resource file does not seem
like a good idea. Perhaps it would be better to use some script to
translate the original resource file, instead of changing it permanently
-- I guess the very first edit in the resource editor would revert such
changes (if the editor would work at all).

--
With Best Wishes,
Constantin

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
VNC-Tight-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/vnc-tight-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patches for compilation with mingw32-gcc-4.1.2

Dick-22
Op zaterdag 30-06-2007 om 15:21 uur [tijdzone +0700], schreef Constantin
Kaplinsky:
> I think this particular change does not look good:
>
> -     SETPIXEL(m_hBitmapDC, j,k, COLOR_FROM_PIXEL##bpp##(pix)); \
> +     SETPIXEL(m_hBitmapDC, j,k, COLOR_FROM_PIXEL32(pix)); \
All COLOR_FROM_PIXEL* functions contain the same code (AFAIK) and GCC
doesn't like calling macro's by ### substitution

> Also, changing slashes to backslashes in the resource file does not seem
> like a good idea. Perhaps it would be better to use some script to
> translate the original resource file, instead of changing it permanently
> -- I guess the very first edit in the resource editor would revert such
> changes (if the editor would work at all).
Maybe the rc file should be moved into the res directory so we don't
have to bother about the slashes...

I've attached a new patch with all warnings removed from winvnc (server)

Thanks for your reply,
Dick

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
VNC-Tight-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/vnc-tight-devel

vnc_winsrc.patch (47K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patches for compilation with mingw32-gcc-4.1.2

Constantin Kaplinsky
Hello Dick,

>>>>> Dick wrote:

>> I think this particular change does not look good:
>>
>> -     SETPIXEL(m_hBitmapDC, j,k, COLOR_FROM_PIXEL##bpp##(pix)); \
>> +     SETPIXEL(m_hBitmapDC, j,k, COLOR_FROM_PIXEL32(pix)); \

> All COLOR_FROM_PIXEL* functions contain the same code (AFAIK) and GCC
> doesn't like calling macro's by ### substitution

Ok, I was wrong, the change seems to be ok (actually, it looks like
there should be just one macro at all).

>> Also, changing slashes to backslashes in the resource file does not seem
>> like a good idea. Perhaps it would be better to use some script to
>> translate the original resource file, instead of changing it permanently
>> -- I guess the very first edit in the resource editor would revert such
>> changes (if the editor would work at all).

> Maybe the rc file should be moved into the res directory so we don't
> have to bother about the slashes...

Yes, that's a good idea I think.

Ok, I'll have a closer look at the patch when I'll have some spare time,
and will start applying the changes to the SVN.

Thank you!

--
With Best Wishes,
Constantin


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
VNC-Tight-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/vnc-tight-devel
Loading...